Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=613001 --- Comment #24 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> 2011-03-30 01:25:53 EDT --- (In reply to comment #23) > I've put a (heavily) modified version of the package here: Cool, thanks for putting this together. Rok, as the official submitter, are you interested in merging these changes in? Here are my initial comments. IMHO it is more straightforward to use what you've done with libdir and mirror that in includedir. The conflicts guidelines on the wiki says "Header Name Conflicts - Put the headers in a subdirectory of /usr/include". So, we should use, eg. /usr/include/heimdal/gssapi/gssapi.h instead of /usr/include/gssapi.heimdal/gssapi.h. This gets even more complicated when there is stuff like /usr/include/krb5.h.heimdal and /usr/include/gssapi.h.heimdal . IMHO, just put these all in a subdirectory and be done with it. I.e. --includedir=%{_includedir}/heimdal There are some other things that were the result of redefining %{_prefix} --with-openssl=/usr \ --with-openldap=/usr \ --with-readline-include=/usr/include/readline \ --with-readline-lib=%{_libdir} \ --with-sqlite3=/usr \ These can go back to using macros. Eg --with-openssl = %{_prefix} , or --with-readline-include = %{_includedir}/readline > - Decide what to do about the other utilities (e.g.: ftp, login, pagsh, rcp, > rsh, su, telnet) that conflict with other packages. MIT puts these utilities in krb5-appl-clients. We could break Heimdal's versions into a similar sub-package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review