Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691673 --- Comment #2 from Iain Arnell <iarnell@xxxxxxxxx> 2011-03-29 10:22:33 EDT --- APPROVED. The license is a little iffy; the only mention of license is in META.yml. You should really have upstream explicitly state somewhere that it's really under the same terms as Perl itself. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2957067 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 274036bd6329230f37009f16f218ca997f7dbb4e Module-Mask-0.03.tar.gz 274036bd6329230f37009f16f218ca997f7dbb4e Module-Mask-0.03.tar.gz.srpm Final provides / requires are sane: ======> perl-Module-Mask-0.03-1.fc16.noarch.rpm <====== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides perl(Module::Mask) = 0.03 perl-Module-Mask = 0.03-1.fc16 ====> requires perl(Carp) perl(Carp::Heavy) perl(:MODULE_COMPAT_5.12.3) perl(Module::Util) >= 1.00 perl(Scalar::Util) perl(strict) perl(warnings) ====> obsoletes ====> conflicts ======> perl-Module-Mask-0.03-1.fc16.src.rpm <====== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides ====> requires perl >= 1:5.8.0 perl(Module::Build) perl(Module::Util) >= 1.00 perl(Test::More) perl(Test::Pod) >= 1.14 perl(Test::Pod::Coverage) >= 1.04 ====> obsoletes ====> conflicts ====> mock install INFO: mock.py version 1.1.9 starting... State Changed: init plugins INFO: selinux enabled State Changed: start Mock Version: 1.1.9 INFO: Mock Version: 1.1.9 State Changed: lock buildroot INFO: installing package(s): perl-Module-Mask-0.03-1.fc16.noarch.rpm INFO: ================================================================================ Package Arch Version Repository Size ================================================================================ Installing: perl-Module-Mask noarch 0.03-1.fc16 /perl-Module-Mask-0.03-1.fc16.noarch 9.9 k Installing for dependencies: perl-CPAN noarch 1.9402-156.fc16 fedora 246 k perl-Digest-SHA x86_64 1:5.47-156.fc16 fedora 63 k perl-ExtUtils-MakeMaker noarch 6.56-156.fc16 fedora 289 k perl-ExtUtils-ParseXS noarch 1:2.2206-156.fc16 fedora 44 k perl-Module-Util noarch 1.07-6.fc15 fedora 22 k perl-Test-Harness noarch 3.17-156.fc16 fedora 239 k perl-devel x86_64 4:5.12.3-156.fc16 fedora 448 k python x86_64 2.7.1-6.fc15 fedora 73 k systemtap-sdt-devel x86_64 1.4-5.fc16 fedora 41 k Transaction Summary ================================================================================ Install 10 Package(s) Total size: 1.4 M Total download size: 22 k Installed size: 3.9 M Installed: perl-Module-Mask.noarch 0:0.03-1.fc16 Dependency Installed: perl-CPAN.noarch 0:1.9402-156.fc16 perl-Digest-SHA.x86_64 1:5.47-156.fc16 perl-ExtUtils-MakeMaker.noarch 0:6.56-156.fc16 perl-ExtUtils-ParseXS.noarch 1:2.2206-156.fc16 perl-Module-Util.noarch 0:1.07-6.fc15 perl-Test-Harness.noarch 0:3.17-156.fc16 perl-devel.x86_64 4:5.12.3-156.fc16 python.x86_64 0:2.7.1-6.fc15 systemtap-sdt-devel.x86_64 0:1.4-5.fc16 State Changed: unlock buildroot -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review