Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691635 --- Comment #5 from elad <el.il@xxxxxxxxxx> 2011-03-29 04:36:56 EDT --- (In reply to comment #4) > Thank you for the review. > > > 1. I'm not sure about the directory in which you located the py and pyc files > > (seems wrong to me). Please read > > https://fedoraproject.org/wiki/Packaging:Python for more information. > > I checked up on this already. I'm not sure either. As of now, the files are > placed where the make script puts them. I'll contact upstream to confirm. > Well I think it's not an upstream issue but rather a packaging issue. Please try to install it in a normal location for python files (written in the guidelines) and if it works, then use it. If not, report a bug to the upstream. > > 2. Please ask upstream to include license in the git repository (and tarballs, > > when upstream releases those) so that you can include the license file in your > > package. > > I'll do that and include a license as a SOURCE: in the meantime. Sounds fine. > > > 3. Missing build dependency: pygtk2 > > Weird, it built in mock correctly. Upstream list it as a dependency. > > > 4. Missing run-time dependencies: mobile-broadband-provider-info, ModemManager > > Do I need to specify explicit requires? I think so. > > > 5. You can use %{buildroot} or $RPM_BUILD_ROOT, but you CAN NOT not both in the > > same spec. Read > > https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS > > for more information. > > Corrected. > > > > > Warnings: > > 1. Clean section is not required for Fedora 13 and above. > > Removed. > > > > > Please fix these issues, and update the spec and SRPM accordingly. > > Thanks, > Ankur Please update the spec and SRPM for any change you make, and give a new link for the SRPM. (the spec should also be updated, but with the same link). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review