Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691153 Hushan Jia <hjia@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hjia@xxxxxxxxxx --- Comment #2 from Hushan Jia <hjia@xxxxxxxxxx> 2011-03-29 03:57:56 EDT --- informal review :) [ok] # MUST: rpmlint [0k] # MUST: Package Naming Guidelines . [ok] # MUST: The spec file name [ok] # MUST: Packaging Guidelines . [ok] # MUST: Package license [ok] # MUST: The License field [ok] # MUST: License in %doc [ok] # MUST: The spec file must be written in American English. [ok] # MUST: The spec file for the package MUST be legible. [ok] # MUST: The sources tarball matches upstream [ok] # MUST: The package MUST successfully compile and build [N/A]# MUST: ExcludeArch [ok] # MUST: All build dependencies must be listed in BuildRequires [N/A] # MUST: The spec file MUST handle locales properly. [N/A] # MUST: ldconfig for shared library [N/A] # MUST: Packages must NOT bundle copies of system libraries.[11] [N/A] # MUST: Package relocatable [ok] # MUST: A package must own all directories that it creates. [ok] # MUST: A Fedora package must not list a file more than once in the spec file's %files listings [ok] # MUST: Permissions on files must be set properly. [ok] # MUST: Each package must consistently use macros. [ok] # MUST: The package must contain code, or permissable content. [N/A] # MUST: Large documentation files must go in a -doc subpackage [ok] # MUST: If a package includes something as %doc, it must not affect the runtime of the application [N/A] # MUST: Header files must be in a -devel package [N/A] # MUST: Static libraries must be in a -static package [N/A] # MUST: Library with a suffix goes into -devel package [N/A] # MUST: devel packages must require the base package [ok] # MUST: Packages must NOT contain any .la libtool archives [N/A] # MUST: Packages containing GUI applications include a %{name}.desktop file [ok] # MUST: Packages must not own files or directories already owned by other packages [ok] # MUST: All filenames in rpm packages must be valid UTF-8 [1]$ rpmlint pam_shield.spec pam_shield-0.9.5-2.fc13.src.rpm pam_shield.src: I: enchant-dictionary-not-found en_US 1 packages and 1 specfiles checked; 0 errors, 0 warnings. [2]$ md5sum pam_shield-0.9.5.tar.gz pam_shield/pam_shield-0.9.5.tar.gz cbfcd96fad38943ed78fd4d37307aba2 pam_shield-0.9.5.tar.gz <-- upstream cbfcd96fad38943ed78fd4d37307aba2 pam_shield/pam_shield-0.9.5.tar.gz [3]http://koji.fedoraproject.org/koji/taskinfo?taskID=2956281 - Please preserve the timestamps when installing https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review