Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671862 --- Comment #14 from Renich Bon Ciric <renich@xxxxxxxxxxxxxxxx> 2011-03-29 02:49:58 EDT --- Ok, here are the updated spec and srpm: SPEC: http://renich.fedorapeople.org/SPECS/libzeitgeist.spec SRPM: http://renich.fedorapeople.org/SRPMS/synapse-0.2.4.1-2.fc14.src.rpm I addressed everything... I think... I hope ;=s It works fine now ;) The only thing I want to discuss is this: >* You don't need to install the same document files (in %doc) > in both main and -devel subpackages Ok. But, what if someone installs either of them? License and README should be in both, don't you think? Maybe the Changelog too? >* "INSTALL" file is generally for people who want to compile / install > packages by themselves and not needed for people trying to install > them via rpm I agree... but, since it's part of the package, maybe it shouldn't be omitted... maybe somebody want's to verify/upgrade/rebuild the package? What do you think? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review