Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690360 --- Comment #3 from Justin Morgan <jpmorgan@xxxxxxxxxxxxxxxxxxx> 2011-03-28 23:05:24 EDT --- (In reply to comment #2) > Are the BuildRequires really needed? Please preserve the timestamps > (https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps). No they aren't. Thank you for pointing that out. I've also added -p arguments to preserve timestamps. Here's the 0.1-2 release with your recommended changes: SPEC: http://matrix.senecac.on.ca/~jpmorgan/SPECS/weave.spec SRPM: http://matrix.senecac.on.ca/~jpmorgan/SRPMS/weave-0.1-2.fc14.src.rpm SOURCE: http://matrix.senecac.on.ca/~jpmorgan/SOURCES/weave-0.1-2.tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review