Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691541 --- Comment #2 from Deepak Bhole <dbhole@xxxxxxxxxx> 2011-03-28 18:01:06 EDT --- (In reply to comment #1) > Packaging Guidelines: > > - Naming: OK. > - Version and Release: OK > - MD5 sum of source tar matches with upstream: OK > - Spec Legibility: OK > - Architecture Support: Issues > Any reason for ExclusiveArch? > - File System Layout: OK > Ideally icedtea-web should install into a normal prefix, not into a JDK dir.But > since this is how upstream is handling it _and_ how this was handled when it > was a part of java-1.6.0-openjdk-plugin, this is OK for now. > - rpmlint: OK > icedtea-web.spec:97: W: configure-without-libdir-spec > This is the same problem as above. OK for now. > icedtea-web.spec:42: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: > line 42) > Please fix this? Fixed. > - Requires: OK > - BuildRequires: OK > - Summary and Description: OK > - Documentation: Issues > Please use %{_javadocdir} for javadoc directory path. The javadoc package needs Fixed. > to be declared as noarch. > - Compiler Flags: Issues > Compiler flags (RPM_OPT_FLAGS, etc) are not being passed. Fixed. > - DebugInfo Packages: OK > - Devel Packages: N/A > - Requiring Base Package: Issues > The Javadocs dont depend on the main package for functionality; please remove > the requires on main package. Done. > - Static and Shared Libraries: OK > - Desktop files: OK > - Macros: Issues > %define used instead of %global. Please use %global > - Scriptlets: OK > I dont understand why only the first alternatives command in %post is if'd. > Shouldnt the second alternatives invocation be if'd as well? Actually, the if in %post shouldn't be an if at all. I had copied and pasted it from the original rpm. We want it to run each time. The if has been removed now. The one in %postun needs to stay in an if as we want it to run only during uninstall and not during upgrade. > - File and directory ownership: OK > - Others: > Please remove all invocations of rm -rf $RPM_BUILD_ROOT. It is unneeded on > recent version of Fedora. Done. New spec file and srpm uploaded. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review