Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689685 --- Comment #2 from elad <el.il@xxxxxxxxxx> 2011-03-28 10:25:21 EDT --- + Package meets naming and packaging guidelines + Spec file matches base package name. ? Spec has consistent macro usage. ? Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. ? Sources match upstream md5sum: - Package needs ExcludeArch ? BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. - Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. (Only spelling warnings, which are wrong) - final provides and requires are sane: SHOULD Items: - Should build in mock. - Should build on all supported archs - Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version Issues: 1.Replace every instance of anchorman with %{name} 2.Replace the version in the source URL to %{version} 3.Use %{_bindir} instead of /usr/bin 4.BuildRequires missing: gcc-c++ (cmake didn't want to configure without this package installed) 4.Please provide md5 sum for released tarball. Warnings: 1.Clean section is not required for Fedora 13 or above 2.I think you should change the summary, it does not matching the description (it's a webcam streaming application, not a recording studio) 3.Your test section is broken, It outputs ********************************* No test configuration file found! ********************************* and then the usage information. 4.(Not directly related to the review): Your project's fedorahosted page lists the wrong link for anonymous git access. Please fix these errors and warnings, and update the spec and SRPM accordingly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review