Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=653800 Mario BlÃttermann <mariobl@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mariobl@xxxxxxxxx --- Comment #4 from Mario BlÃttermann <mariobl@xxxxxxxxx> 2011-03-27 14:11:31 EDT --- (In reply to comment #2) > The last release has been made 5 years ago. This software really looks > deprecated, I would think twice before importing it in Fedora.. Doesn't matter, I'm packaging WindowMaker dockapps which are sometimes even longer down than five years. Some initial issues: - The tab indents in the header should be tweaked a bit, for better readability. - Use macros wherever possible: Replace all occurences of the package name with %{name}. - Add a -p switch to the install calls to keep timestamps. - The file allfs.h has the executable bit set, please remove it (of course the bit itself, not the file ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review