Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gstreamer-plugins-farsight - GStreamer plug-ins for farsight protocol https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207685 jspaleta@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|63778 |163779 nThis| | ------- Additional Comments From jspaleta@xxxxxxxxx 2006-12-22 21:19 EST ------- GOOD: *Built in mock on i386 against fedora-development *rpmlint runs cleanly against it *follows naming guidelines for addon packages *licnese is GPL and spec tag matches *COPYING file in %doc *spec in US/english and legible *Include source matches upstream md5sum 77c92554c2bd57ad1b426e5ba50eb9a8 gst-plugins-farsight-0.10.2.tar.gz *buildrequires look good *no locales to worry about *only gstreamer plugin so's no shared libs in default linker path *not relocatable *does not create any unowned directories. Package requires gstreamer-plugins-base which in turns requires gstreamer which owns /usr/lib/gstreamer-0.10 *no duplicates in %files *file permissions seem fine *install and clean sections look good *macro use is consistent *docs is good *no -devel subpackage *la files removed in install section *not a gui, no desktop file needed *appears to meet all packaging guidelines One small thing I'd like to see changed. Can you rename the macro at from majorminor to gst_majorminor? I was slightly confused initially because its the same numerical value as the package version majorminor. Its clear now its a macro to define the gstreamer majorminor, but it would be helpful for clarity to change the name to gst_majorminor. This is not a blocker however, but it may help save a little time if someone has to pick this package up from you later. This package is APPROVED for entry into the development tree. I haven't tested this yet, I'm be building stream-engine next so I can test this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review