Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690519 --- Comment #3 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-03-24 11:56:11 EDT --- > - License is specified as ASL 2.0 in most of the source code files. > - However, some files do not mention a license at all, just the copyright. > - The included COPYING contains a BSD license. > => License tag should read ASL 2.0 and BSD just to be on the safe side. > > Please ask upstream to clarify the licensing. I already asked upstream to replace the BSD license text with the ASL 2.0 one: http://code.google.com/p/snappy/issues/detail?id=20&can=1 It's a known issue that has already been fixed in the SVN repo. This is also true for the missing/incomplete copyright info in the source files. Since the library is definitely licensed under ASL 2.0, I'd rather omit COPYING for now and add it as soon as a new release of snappy is available. > MUST: Optflags are used and time stamps preserved. OK > - Although IMHO using > CXXFLAGS="%{optflags} -DNDEBUG" > would be better. Sure. Fixed. > MUST: All relevant items are included in %doc. Items in %doc do not affect > runtime of application. NEEDSWORK > - Please remove empty %doc line from -devel. Done. New files: Spec URL: http://mgieseki.fedorapeople.org/snappy/snappy.spec SRPM URL: http://mgieseki.fedorapeople.org/snappy/snappy-1.0.0-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review