Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688408 --- Comment #13 from Hicham HAOUARI <hicham.haouari@xxxxxxxxx> 2011-03-22 12:14:26 EDT --- (In reply to comment #12) > Too bad I wasn't aware of this review. Next time you package something for > Xfce, please ping the Xfce SIG. Right, I talked to nirik before submitting it. > > I packaged this plugin earlier, but we agreed to not include it in Fedora for > several reasons: > * Usually the power managers take care of scaling the CPU frequency. Right > * The plugin does not work with Fedora's default setup. Scaling is only allowed > for root or through PolicyKit, but the plugin doesn't support the latter. How > did you make the plugin work? I missed that, I will work with upstream to add polkit support ASAP. > * There usually is no need for changing frequencies or the governor, ondemand > will handle this best. I don't agree, under certain conditions I want to force the cpu to use a certain frequency to keep my laptop cool. > > Some notes on the package: > 1) The description is formatted a little strange Define "strange". > 2) "Requires: hicolor-icon-theme" is not needed because the plugin requires > gtk2 which already has a dependency to hicolor-icon-theme. Right > 3) The Requires for xfce4-panel should be versioned and the version should be > adjusted for the different Fedora releases. A plugin built for Xfce4-panel > xfce4-panel 4.8 will not work with 4.6 or 4.4, even though the srpm is the > same. I will work on that Thanks Christoph for helping with this review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review