Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=689056 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-03-22 06:38:10 EDT --- (In reply to comment #1) > File tlog is licensed under GPLv2+, so License must be: GPLv2 + GPLv2+ It would be "GPLv2 and GPLv2+". However, I'd prefer a consistent licensing scenario for the whole package. Mark, please ask upstream whether tlog is actually intended to be licensed under GPLv2+ while all other scripts are GPLv2 only. Here are some additional comments: - "lmd" seems to be the abbreviation of the project name. However, upstream uses "maldetect" for the tarball and all related files/folders. Therefore, I personally would tend to name the package "maldetect" as well. - You should drop Requires: perl as this dependency is detected automatically. - Please use plain rm, cp, and sed instead of the corresponding macros. See also: http://fedoraproject.org/wiki/Packaging/Guidelines#Macros - The package currently doesn't own the folders %{_datadir}/maldetect, %{_var}/lib/maldetect, and %{_libexecdir}/maldetect but only their contents. Just remove the asterisks in the %file section to get it right. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review