Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673030 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul@xxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |paul@xxxxxxxxxxxx Flag| |fedora-review+ --- Comment #4 from Paul Howarth <paul@xxxxxxxxxxxx> 2011-03-21 12:39:21 EDT --- rpmlint output: perl-Locale-US.noarch: W: spelling-error Summary(en_US) versa -> avers, verse, verst perl-Locale-US.noarch: W: spelling-error %description -l en_US versa -> avers, verse, verst perl-Locale-US.src: W: spelling-error Summary(en_US) versa -> avers, verse, verst perl-Locale-US.src: W: spelling-error %description -l en_US versa -> avers, verse, verst 2 packages and 1 specfiles checked; 0 errors, 4 warnings. These warnings are due to deficiencies in the US English dictionary and can be dismissed. Review checklist: - package and spec file naming OK - package meets guidelines - license is OK for Fedora and matches upstream - spec file written in English and is legible - source tarball matches upstream - package builds fine in mock for Rawhide (x86_64) - buildreqs OK - no locales, libraries, devel files etc. to concern us - package not intended to be relocatable - directory ownership is fine - no duplicate files - permissions fine - macro usage is consistent - code, not content - no large docs - not a GUI app - works fine as part of Moose test suite Requires: perl(:MODULE_COMPAT_5.12.3) rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 perl >= 0:5.006001 perl(Exporter) perl(strict) perl(warnings) rpmlib(PayloadIsXz) <= 5.2-1 Provides: perl(Locale::US) = 1.2 perl-Locale-US = 1.2-2.fc16 Why not ship kruft2codes.pl as %doc rather than just deleting it, since it's mentioned in the POD? May as well fix the mis-spellings too: https://rt.cpan.org/Public/Bug/Display.html?id=62218 Is %{?perl_default_filter} actually needed? No blockers here. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review