Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |paul@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Paul Howarth <paul@xxxxxxxxxxxx> 2011-03-21 10:37:06 EDT --- rpmlint output: perl-XML-Rules.noarch: W: file-not-utf8 /usr/share/doc/perl-XML-Rules-1.10/example/testUTF.txt perl-XML-Rules.noarch: W: file-not-utf8 /usr/share/doc/perl-XML-Rules-1.10/example/testUTF.pl perl-XML-Rules.noarch: W: file-not-utf8 /usr/share/doc/perl-XML-Rules-1.10/example/test19.txt perl-XML-Rules.noarch: W: file-not-utf8 /usr/share/doc/perl-XML-Rules-1.10/example/test18.xml These files are either explicitly encoded using some ither encoding, or are generated from such a file, so these warnings can be dismissed. - package and spec file name as per guidelines - package meets guidelines - license is OK for Fedora and matches upstream - upstream license text included in package - spec file written in English and is legible - source matches upstream - builds OK in mock for Rawhide x86_64 - buildreqs look OK - no locales, libraries, devel files etc. to concern us - package is not intended to be relocatable - directory ownership is fine - no duplicate files - no permissions problems - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - not a GUI application - all filenames OK - no scriptlets - requires/provides are OK - test suite passes cleanly - package installs cleanly Requires perl >= 0:5.008 perl(:MODULE_COMPAT_5.12.3) perl(Carp) perl(Exporter) perl(Scalar::Util) perl(XML::Parser) >= 2.00 perl(XML::Parser::Expat) perl(XML::Parser::Expat) >= 2.00 perl(constant) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 Provides perl(XML::Rules) = 1.10 perl-XML-Rules = 1.10-1.fc16 Quibbles - the blank line after %description is treated as part of the package description, so it's best not to have it there - it's best not to assume that RPM will use gzip to compress manpages as this may change in the future; better change: %{_mandir}/man3/XML::Rules.3pm.gz to: %{_mandir}/man3/XML::Rules.3pm* - I'd suggest shipping the two scripts you removed from %{_bindir} as %doc - do you intend to build these packages for EPEL-4 or EPEL-5? If not, you can skip cleaning the buildroot in %install, skip %clean altogether and drop the BuildRoot: tag -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review