Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-timer-plugin - Timer for the Xfce panel https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219990 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pertusus@xxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From pertusus@xxxxxxx 2006-12-21 09:14 EST ------- * rpmlint is silent * free software, license included * follow packaging guidelines * follow naming guidelines except if there is some specific guideline for panel applets, but it doesn't seems so (I remember vaguely some discussion) * match upstream: fe20a7c1bba78d6c2a7483a894294155 xfce4-timer-plugin-0.5.tar.bz2 * sane provides * %files section right * seems to have everything needed for an xfce panel applet (although I didn't test). APPROVED There are the usual unneeded dependencies on sonames: $ ldd -u -r /usr/libexec/xfce4/panel-plugins/xfce4-timer Unused direct dependencies: /usr/lib/libgdk-x11-2.0.so.0 /usr/lib/libatk-1.0.so.0 /usr/lib/libgdk_pixbuf-2.0.so.0 /lib/libm.so.6 /usr/lib/libpangocairo-1.0.so.0 /usr/lib/libpango-1.0.so.0 /usr/lib/libcairo.so.2 /lib/libgmodule-2.0.so.0 /lib/libdl.so.2 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review