[Bug 683071] Review Request: php-libvirt - PHP bindings for libvirt virtualization toolkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683071

--- Comment #26 from Tomas Mraz <tmraz@xxxxxxxxxx> 2011-03-14 13:29:44 EDT ---
I have still some additional requests. The build process is still not quite
right - the CPPFLAGS/CFLAGS/LDFLAGS passed from the rpmbuild are ignored when
the .c code is compiled and the .so linked. This makes the debuginfo empty
which is why you disabled it. But that isn't acceptable, you have to patch the
build so the debuginfo can be extracted.

Also in the %changelog - do not use the .fcxx dist suffix as the package can be
rebuilt on various dist releases.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]