Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683587 --- Comment #2 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> 2011-03-14 04:46:58 EDT --- (In reply to comment #1) > I saw your comment about the ACSS in the SPEC file but i think this would be > much much clearer if you used the upstream openssh package and added a patch > file that removes the ACCS cipher. > > Fedora reviewing guidelines require: > MUST: The sources used to build the package must match the upstream source, as > provided in the spec URL. Reviewers should use md5sum for this task. If no > upstream URL can be specified for this package, please see the Source URL > Guidelines for how to deal with this. Most of the gsissh specfile is copied from the openssh specfile, including the part regarding the source. The source tarball is the same as in the openssh package. It is not possible to do the removal of the ACCS sources in %prep only, since they can not be legally distributed. This is not a case of "make sure the code is not used during the build", but a case of "make sure the sources are not illegally redistributed by Fedora inside the source RPM". The spec is compliant with the guidelines for this case: http://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review