Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=671883 Peter Robinson <pbrobinson@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #13 from Peter Robinson <pbrobinson@xxxxxxxxx> 2011-03-14 02:07:23 EDT --- (In reply to comment #12) > (In reply to comment #10) > > Mostly OK. I think the QT app needs a desktop file (but it might not be an app > > that shoud) and there should be versioned required on the libs at a guess for > > the various utils. > > > > Thanks for the review, and sorry for the slow reply (I was swamped with work, > on a business trip amongst other things. > > > - non -devel packages should require fully versioned base > > - packages containing GUI apps must include %{name}.desktop file > > > > Both fixed, here is a new version: > http://people.fedoraproject.org/~jwrdegoede/v4l-utils.spec > http://people.fedoraproject.org/~jwrdegoede/v4l-utils-0.8.3-2.fc15.src.rpm Build fails. You need to add a dep on desktop-file-utils for the desktop file processing. http://koji.fedoraproject.org/koji/getfile?taskID=2910226&name=build.log But other than that it all looks OK so APPROVED! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review