Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680657 --- Comment #6 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-03-13 17:28:09 EDT --- (In reply to comment #5) > Well, the first barrier here is that, as is often the case when you have one > piece of code with an odd license, this is a bundled library. Is this one of > the md5 libraries we've already approved for bundling? > https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries > > If so you'll at minimum need to add the Provides: bundled(md5-whatever) bit. > If not, FPC will need to review the situation. > > As for the license issue, of course the license of the actual files present in > the binary package are significant (as told in the URLs I've already provided). > If it is not obvious how the licenses combine, you will need to get an opinion > from the legal folks. Hey, It appears to be the "Peter Deutsch's version: bundled(md5-deutsch) " version. I've added a virtual provides. SPEC:http://ankursinha.fedorapeople.org/mpdas/mpdas.spec SRPM:http://ankursinha.fedorapeople.org/mpdas/mpdas-0.3.0-2.fc14.src.rpm rpmlint outputs: (They don't look major, I'll look into them as the review progresses) [ankur@ankur SPECS]$ rpmlint mpdas.spec ../SRPMS/mpdas-0.3.0-2.fc14.src.rpm ../RPMS/x86_64/mpdas-0.3.0-2.fc14.x86_64.rpm mpdas.spec:15: W: unversioned-explicit-provides bundled(md5-deutsch) mpdas.spec:29: W: rpm-buildroot-usage %build CXXFLAGS=$RPM_OPT_FLAGS PREFIX=$RPM_BUILD_ROOT%{_prefix} MANPREFIX=$RPM_BUILD_ROOT%{_mandir} mpdas.spec:15: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 15) mpdas.src: W: spelling-error Summary(en_US) audioscrobbling -> audiological, audiocassette, audiovisuals mpdas.src: W: spelling-error Summary(en_US) clien -> cline, lien, client mpdas.src: W: spelling-error %description -l en_US libmpd -> libido, limpid, Librium mpdas.src: W: spelling-error %description -l en_US libcurl -> lib curl, lib-curl, liberal mpdas.src:15: W: unversioned-explicit-provides bundled(md5-deutsch) mpdas.src:29: W: rpm-buildroot-usage %build CXXFLAGS=$RPM_OPT_FLAGS PREFIX=$RPM_BUILD_ROOT%{_prefix} MANPREFIX=$RPM_BUILD_ROOT%{_mandir} mpdas.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 15) mpdas.x86_64: W: spelling-error Summary(en_US) audioscrobbling -> audiological, audiocassette, audiovisuals mpdas.x86_64: W: spelling-error Summary(en_US) clien -> cline, lien, client mpdas.x86_64: W: spelling-error %description -l en_US libmpd -> libido, limpid, Librium mpdas.x86_64: W: spelling-error %description -l en_US libcurl -> lib curl, lib-curl, liberal 2 packages and 1 specfiles checked; 0 errors, 14 warnings. Thanks! Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review