Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683150 Raghu Udiyar <raghusiddarth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |raghusiddarth@xxxxxxxxx --- Comment #2 from Raghu Udiyar <raghusiddarth@xxxxxxxxx> 2011-03-13 10:59:02 EDT --- Hi, Just a few comments : - BuildRoot tag is not required any more : http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag - %clean section not required for F13 and above http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean - Use desktop-file-validate : http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage - Upstream seems to have released a new version (0.9.1), please update the package to this release. - Run rpmlint and fix the errors/warnings it throws. Here's what I got : $ rpmlint yad.spec ../RPMS/i686/yad-* ../SRPMS/yad-0.9.0-1.fc14.src.rpm yad.spec: W: invalid-url Source0: http://yad.googlecode.com/files/yad-0.9.0.tar.xz HTTP Error 404: Not Found yad.i686: W: spelling-error Summary(en_US) dialogs -> dialog, dialog s, dialings yad.i686: W: spelling-error %description -l en_US dialogs -> dialog, dialog s, dialings yad.i686: W: no-manual-page-for-binary yad-icon-browser yad-devel.i686: W: no-documentation yad-devel.i686: W: no-manual-page-for-binary yad-icon-browser yad.src: W: spelling-error Summary(en_US) dialogs -> dialog, dialog s, dialings yad.src: W: spelling-error %description -l en_US dialogs -> dialog, dialog s, dialings yad.src: W: invalid-url Source0: http://yad.googlecode.com/files/yad-0.9.0.tar.xz HTTP Error 404: Not Found 4 packages and 1 specfiles checked; 0 errors, 9 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review