Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675689 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #3 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2011-03-13 01:20:00 EST --- Thanks for the review. (In reply to comment #2) > Nice catch with the missing dep on older fedora, but the test should be > '%if 0%{?fedora} < 15' to avoid build failure if %fedora isn't defined at all. > > APPROVED with that one small fix. OK, I'll add this (It was slip through on my part), however as the package probably won't be buildable on anything but Fedora, this argument is mostly moot, anyway ;) New Package SCM Request ======================= Package Name: perl-Test-Log-Dispatch Short Description: Test what you are logging Owners: corsepiu Branches: f13 f14 f15 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review