Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684446 Rahul Sundaram <metherid@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |metherid@xxxxxxxxx --- Comment #1 from Rahul Sundaram <metherid@xxxxxxxxx> 2011-03-12 14:04:50 EST --- Not a full review yet but here is some initial feedback: " Initial efforts are focused on porting to the Linux 2.6 kernel" * Drop this from the description. * You don't need to define the buildroot or have a %clean section http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean * Does %setup really require passing name and version to it? * You need to use %configure macro and not use ./configure * Must use %defattr(-,root,root,-) * Should not package .la file http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries * Header files and pkgconfig files belong in a -devel package * You should use a %check and run the in-built test suite -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review