Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684239 --- Comment #5 from Raul Gutierrez S. <rgs@xxxxxxxxxxxxx> 2011-03-12 09:11:25 EST --- Thanks for reviewing this! My comments in-lined: (In reply to comment #4) > There is some issues > > [!] : MUST - Package successfully compiles and builds into binary rpms on at > least one supported architecture. > checking pkg-config is at least version 0.9.0... yes > checking for LIBGVC... yes > checking for GLIB... no > configure: error: Package requirements (glib-2.0 >= 2.12.0 gobject-2.0 > >= 2.12.0) were not met: > No package 'glib-2.0' found > No package 'gobject-2.0' found > Consider adjusting the PKG_CONFIG_PATH environment variable if you > installed software in a non-standard prefix. > Alternatively, you may set the environment variables GLIB_CFLAGS > and GLIB_LIBS to avoid the need to call pkg-config. > See the pkg-config man page for more details. > error: Bad exit status from /var/tmp/rpm-tmp.IlkXRX (%build) > Bad exit status from /var/tmp/rpm-tmp.IlkXRX (%build) > RPM build errors: > > I can build the package in mock looks like some buildrequires are missing > I've refreshed the SPEC file adding a couple of BuildRequires to ensure we have what is needed. > [!] : MUST - Sources used to build the package matches the upstream source, as > provided in the spec URL. > MD5SUM this package : 97cfccf239cd296dcaf7c854788a31e6 > MD5SUM upstream package : 53b414fc53f2413117ced5b06e5a9d74 > > The package checksum don't match upstream. > > Looks like the download url is some kind of auto-generated tarball, with at new > checksum everytime :(. > > 1. You should ask upstream if there could make reel release tarball somewhere. > 2. check http://fedoraproject.org/wiki/Packaging/SourceURL for the rules to > package a git snapshot. > I any case there should be some comments in the spec about why the source > checksum don't match. >From asking and looking at git tag (no tags) it seems upstream hasn't made a release yet. So I went ahead and added comments on how to generate a tarball. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review