Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670477 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |iarnell@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |iarnell@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Iain Arnell <iarnell@xxxxxxxxx> 2011-03-12 03:08:23 EST --- + source files match upstream. c26795112c9f616dbd37ece1c5895b55 HTTP-Server-Simple-PSGI-0.14.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=2906114 + package installs properly. + rpmlint has no complaints: 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + final provides and requires are sane: perl(HTTP::Server::Simple::PSGI) = 0.14 perl-HTTP-Server-Simple-PSGI = 0.14-1.fc16 perl(HTTP::Server::Simple::PSGI::Writer) = perl >= 0:5.005_03 perl(base) perl(HTTP::Server::Simple::CGI) perl(:MODULE_COMPAT_5.12.3) perl(strict) perl(vars) + %check is present and all tests pass. PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00_compile.t .. ok All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.03 cusr 0.00 csys = 0.04 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review