[Bug 683610] Review Request: hxtools - A collection of several tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683610

Sergio Belkin <sebelk@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sebelk@xxxxxxxxx

--- Comment #4 from Sergio Belkin <sebelk@xxxxxxxxx> 2011-03-11 17:29:40 EST ---
Some comments:

*BuildRequires:
- You are using autoreconf in autogen.sh, so you must include it.

*Remove the blank line at the end of the file.

The following are not oficially part of guideliness (but I think that are in
its spirit):

*Summary
- The problem with hxtools summary is that says nothing specific to the
package! Would you install some package that you ever heard in the life with
such a description? :-)

*Well let's read the description
- Oh, I see, now it's clear enough! No, not really, I am joking. You are
forcing to either read the code, go to the project site or read the man pages

*I think you made two interesting programs that make *two specific tasks" Why
don't you make two different packages in the UNUX-style? :)

HTH

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]