[Bug 683071] Review Request: php-libvirt - PHP bindings for libvirt virtualization toolkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683071

--- Comment #20 from Michal Novotny <minovotn@xxxxxxxxxx> 2011-03-11 09:39:28 EST ---
(In reply to comment #19)
> OK, fine.
> 
> There is double call to configure in the spec.%configure
> %configure
> ./configure --with-html-dir=%{_datadir}/doc
> --with-html-subdir=%{name}-%{version}/html --libdir=%{php_extdir}
> 
> The %configure is a macro that expands to the configure call.

Well, if I change:

%build
%configure
./configure --with-html-dir=%{_datadir}/doc
--with-html-subdir=%{name}-%{version}/html --libdir=%{php_extdir}
make %{?_smp_mflags}

to:

%build
%configure
make %{?_smp_mflags}

then I'm getting errors about unpackaged files:

Checking for unpackaged file(s): /usr/lib/rpm/check-files
/home/mig/RPMS/BUILDROOT/php-libvirt-0.4.1-2.fc14.i386
error: Installed (but unpackaged) file(s) found:
   /usr/share/doc/libvirt-php-0.4.1/html/32favicon.png
   /usr/share/doc/libvirt-php-0.4.1/html/api-reference.html
   /usr/share/doc/libvirt-php-0.4.1/html/compiling.html
   /usr/share/doc/libvirt-php-0.4.1/html/contact.html
   /usr/share/doc/libvirt-php-0.4.1/html/contributions.html
   /usr/share/doc/libvirt-php-0.4.1/html/deployment.html
   /usr/share/doc/libvirt-php-0.4.1/html/dev-api-reference.html
   /usr/share/doc/libvirt-php-0.4.1/html/docs.html
   /usr/share/doc/libvirt-php-0.4.1/html/downloads.html
   /usr/share/doc/libvirt-php-0.4.1/html/examples.html
   /usr/share/doc/libvirt-php-0.4.1/html/footer_corner.png
   /usr/share/doc/libvirt-php-0.4.1/html/footer_pattern.png
   /usr/share/doc/libvirt-php-0.4.1/html/generic.css
   /usr/share/doc/libvirt-php-0.4.1/html/index.html
   /usr/share/doc/libvirt-php-0.4.1/html/libvirt-header-bg.png
   /usr/share/doc/libvirt-php-0.4.1/html/libvirt-php-header-logo.png
   /usr/share/doc/libvirt-php-0.4.1/html/libvirt.css
   /usr/share/doc/libvirt-php-0.4.1/html/links.html
   /usr/share/doc/libvirt-php-0.4.1/html/main.css
   /usr/share/doc/libvirt-php-0.4.1/html/news.html
   /usr/share/doc/libvirt-php-0.4.1/html/references.html
   /usr/share/doc/libvirt-php-0.4.1/html/roadmap.html
   /usr/share/doc/libvirt-php-0.4.1/html/sitemap.html
   /usr/share/doc/libvirt-php-0.4.1/html/todo.html
   /usr/share/doc/libvirt-php-0.4.1/html/windows.html


RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/share/doc/libvirt-php-0.4.1/html/32favicon.png
   /usr/share/doc/libvirt-php-0.4.1/html/api-reference.html
   /usr/share/doc/libvirt-php-0.4.1/html/compiling.html
   /usr/share/doc/libvirt-php-0.4.1/html/contact.html
   /usr/share/doc/libvirt-php-0.4.1/html/contributions.html
   /usr/share/doc/libvirt-php-0.4.1/html/deployment.html
   /usr/share/doc/libvirt-php-0.4.1/html/dev-api-reference.html
   /usr/share/doc/libvirt-php-0.4.1/html/docs.html
   /usr/share/doc/libvirt-php-0.4.1/html/downloads.html
   /usr/share/doc/libvirt-php-0.4.1/html/examples.html
   /usr/share/doc/libvirt-php-0.4.1/html/footer_corner.png
   /usr/share/doc/libvirt-php-0.4.1/html/footer_pattern.png
   /usr/share/doc/libvirt-php-0.4.1/html/generic.css
   /usr/share/doc/libvirt-php-0.4.1/html/index.html
   /usr/share/doc/libvirt-php-0.4.1/html/libvirt-header-bg.png
   /usr/share/doc/libvirt-php-0.4.1/html/libvirt-php-header-logo.png
   /usr/share/doc/libvirt-php-0.4.1/html/libvirt.css
   /usr/share/doc/libvirt-php-0.4.1/html/links.html
   /usr/share/doc/libvirt-php-0.4.1/html/main.css
   /usr/share/doc/libvirt-php-0.4.1/html/news.html
   /usr/share/doc/libvirt-php-0.4.1/html/references.html
   /usr/share/doc/libvirt-php-0.4.1/html/roadmap.html
   /usr/share/doc/libvirt-php-0.4.1/html/sitemap.html
   /usr/share/doc/libvirt-php-0.4.1/html/todo.html
   /usr/share/doc/libvirt-php-0.4.1/html/windows.html

So apparently the configure is not being called with arguments required and
it's being called with those arguments:

+ ./configure --build=i686-pc-linux-gnu --host=i686-pc-linux-gnu
--program-prefix= --disable-dependency-tracking --prefix=/usr
--exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc
--datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib
--libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib
--mandir=/usr/share/man --infodir=/usr/share/info

instead so the --with-html-dir and --with-html-subdir arguments are missing
there.

Michal

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]