Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666572 Peter Lemenkov <lemenkov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #13 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2011-03-11 09:18:13 EST --- REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable - rpmlint is not completely silent: work ~/Desktop: rpmlint zyGrib-* zyGrib.src: W: spelling-error Summary(en_US) meteo -> metro, mete, meteor zyGrib.src: W: spelling-error %description -l en_US meteo -> metro, mete, meteor zyGrib.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip zyGrib.src: W: spelling-error %description -l en_US gz -> g, z, gaz ^^^ this should be omitted zyGrib.src: W: invalid-url Source0: zyGrib-3.9.9.tgz ^^^ This is also OK (no direct link) zyGrib.x86_64: W: spelling-error Summary(en_US) meteo -> metro, mete, meteor zyGrib.x86_64: W: spelling-error %description -l en_US meteo -> metro, mete, meteor zyGrib.x86_64: W: spelling-error %description -l en_US gzip -> zip, grip, g zip zyGrib.x86_64: W: spelling-error %description -l en_US gz -> g, z, gaz ^^^ This should be omitted zyGrib.x86_64: W: incoherent-version-in-changelog -3.9.9-3 ['3.9.9-3.fc15', '3.9.9-3'] ^^^ This should be fixed (caused by mising space between dash and version in %changelog) zyGrib.x86_64: W: no-manual-page-for-binary zyGrib ^^ That's OK too 3 packages and 0 specfiles checked; 0 errors, 11 warnings. work ~/Desktop: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (GPLv3 or later). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. work ~/Desktop: work ~/Desktop: sha256sum zyGrib-3.9.9.tgz* a2016109e09307e73eeabbbe78ac6814043778a3cd67234bf789f57273a48399 zyGrib-3.9.9.tgz a2016109e09307e73eeabbbe78ac6814043778a3cd67234bf789f57273a48399 zyGrib-3.9.9.tgz.orig work ~/Desktop: + The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji link above. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. 0 The package DOESN'T have a %clean section, so it won't build cleanly on systems with old rpm (EL-4 and EL-5, not sure about EL-6). Beware. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files without a suffix (e.g. libfoo.so). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. + The package includes a %{name}.desktop file, and this file is properly installed with desktop-file-install in the %install section. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. Ok. I can;t find any other issues, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review