Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683071 --- Comment #11 from Michal Novotny <minovotn@xxxxxxxxxx> 2011-03-11 05:32:20 EST --- (In reply to comment #10) > The php-libvirt-0.4.1.tar.gz in the src.rpm and the > http://libvirt.org/sources/php/php-libvirt-0.4.1.tar.gz tarballs still differ. > I don't know how could they still differ however I'll check it later after the rest of the issues are solved. > The upstream project is still named libvirt-php - perhaps the tarball should > stay with the name libvirt-php and just name the src.rpm package php-libvirt? > The upstream project will still be named libvirt-php. We're talking about Fedora name and not upstream name since upstream name will not change. I was having some issues having the tarball named libvirt-php since after renaming the project to php-libvirt it was looking for libvirt-php file instead. When I altered the source to use php-libvirt it was working fine however the upstream tarball named php-libvirt had to exist and therefore I changed to this. > Also I see the license was changed to LGPLv2+ - at least according to the > LICENSE and README files - have you got an approval from all of the > contributors to the project to change the license? You cannot change the > license from GPLv2 to LGPLv2+ without it as the GPLv2 is stronger - more > restrictive license. > > Also the LICENSE and probably also the README file should stay in the base > package as %doc and should not go into the doc subpackage. Well, where exactly should it go since all files installed by the main package are just /etc/php.d/php-libvirt.ini and /usr/lib/php/modules/php-libvirt.so so where should the README and LICENSE files go? Should they be copied to the docs directory even if user don't install the -doc package? Thanks, Michal -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review