Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682414 --- Comment #7 from Ville Skyttà <ville.skytta@xxxxxx> 2011-03-10 17:12:29 EST --- (In reply to comment #6) > Umm.. did you expand the macros? Of course. > I tested it with > $ spectool -g reptyr.spec > and it worked. So did I, and it did *not* work. As said, I additionally tested with wget, curl and Firefox, it didn't work in any of them. > It's not working anymore, since the tarball doesn't exist anymore. The current > snapshot from the master branch is > nelhage-reptyr-reptyr-0.2-2-g919fff7.tar.gz > In the 0.2 tag it is > nelhage-reptyr-reptyr-0.2-2-g919fff7.tar.gz Um, those are the same? And I'm NOT packaging the current master branch snapshot, I'm packaging the 0.2 release. > Note that this is a review blocker. Well, your previous suggestion did not work, and I'm not going to put a URL that I *know* does not work there. See end of this comment for more about this. > However, that way it's just way easier for the maintainer to plug in the > correct snapshot ID in the spec file and run > $ spectool -g package.spec Yes, I have quite a bit of experience with packaging and I'm pretty much the upstream of spectool nowadays, so I know about its use cases as well, and I'll be maintaining this package anyway, so... > Whenever you use snapshots from VCS, you MUST insert the snapshot revision in > the Release field. Oh come on. This is as a "release" as it gets and NOT a random VCS snapshot, there's just (to my knowledge) any way to get sane, stable github tarball download URLs. Or don't you think what upstream tagged as 0.2 is the 0.2 release? Then what is? The tarball sha1sums won't match and github has mangled the base dir inside the 0.2 tarball after I packaged it (mine was nelhage-reptyr-31b85ff, new one I just downloaded is nelhage-reptyr-9f9fd83, but both filenames are nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz), but the contents are *exactly* the same otherwise. Please also look at the git revision mentioned for the 0.2 release at https://github.com/nelhage/reptyr/downloads; it's 31b85ff which is the revision in my package. What else do you want in order to not call this a VCS snapshot but a release? The tarball in my package: $ sha1sum ~/rpmbuild/SOURCES/nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz b8b56a17d4a7efd9ee93295619b7495161b70732 /home/scop/rpmbuild/SOURCES/nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz The 0.2 tarball I get from the tar.gz download link for reptyr-0.2 at https://github.com/nelhage/reptyr/downloads (the tarball link points to "https://github.com/nelhage/reptyr/tarball/reptyr-0.2";): $ wget --no-check-certificate "https://github.com/nelhage/reptyr/tarball/reptyr-0.2"; --2011-03-10 23:39:30-- https://github.com/nelhage/reptyr/tarball/reptyr-0.2 Resolving github.com... 207.97.227.239 Connecting to github.com|207.97.227.239|:443... connected. WARNING: certificate common name â*.github.comâ doesnât match requested host name âgithub.comâ. HTTP request sent, awaiting response... 302 Found Location: https://nodeload.github.com/nelhage/reptyr/tarball/reptyr-0.2 [following] --2011-03-10 23:39:31-- https://nodeload.github.com/nelhage/reptyr/tarball/reptyr-0.2 Resolving nodeload.github.com... 207.97.227.252 Connecting to nodeload.github.com|207.97.227.252|:443... connected. HTTP request sent, awaiting response... 302 Moved Temporarily Location: https://download.github.com/nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz [following] --2011-03-10 23:39:41-- https://download.github.com/nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz Resolving download.github.com... 207.97.227.240 Connecting to download.github.com|207.97.227.240|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 12187 (12K) [application/octet-stream] Saving to: ânelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gzâ 100%[===============================================================================================================================================================================================================>] 12,187 --.-K/s in 0s 2011-03-10 23:39:44 (257 MB/s) - ânelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gzâ saved [12187/12187] $ sha1sum nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz e9d305d9a0b8d9a80644e7cf2987f8078350ed80 nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz ...so the sha1sums don't match, but: $ rpmdev-diff ~/rpmbuild/SOURCES/nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz nelhage-reptyr-reptyr-0.2-0-g31b85ff.tar.gz ...so the contents of the actual files in them are the same. You can also verify it by doing a checkout of the reptyr-0.2 upstream tag and comparing that to the tarballs' contents ("git checkout reptyr-0.2" also outputs "HEAD is now at 31b85ff... reptyr 0.2" -- note again the 31b85ff git revision which IS the 0.2 release). If you won't approve the package as is, I suggest posting a concrete patch or specific steps what you could approve and I'll have a look if I'm fine with them in the sense that I wouldn't consider them as making the package worse and immediately revert them once the package is in, or to step aside and let someone else finish the review, or someone else can continue this submission or post another one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review