Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: horde - php application framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189195 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-12-20 02:00 EST ------- Well, I had set aside time to look at this and then promptly got busy with holiday preparations. But I'm off tomorrow, and so I went ahead and build this and did some preliminary investigations. Here are a few questions: What's the registry.php file for? I see the configuration is in /etc/horde, but that you originally had them in /var/lib/horde. I'm wondering how selinux might ever be made to tolerate apache writing to things under /etc. Frankly I had anticipated them under /var/lib because I'd expect that most users would edit them only via the configuration interface, but I'm honestly not sure which location is more appropriate. Some packages I've seen disable the test.php script. I'm not sure why; it's pretty useful for an administrator to check things out, but I suppose it's not needed in normal use. What do you think? You should probably add a note to README.fedora about how to install the proper database module, just to be kind. Why do you explicitly list out the files/directories under %{_datadir}/%{name}? In general I really like the look of this package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review