Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=683071 Tomas Mraz <tmraz@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(minovotn@xxxxxxxx | |om) --- Comment #3 from Tomas Mraz <tmraz@xxxxxxxxxx> 2011-03-09 08:33:25 EST --- The tarball at the source URL and in the .src.rpm differs. According to the https://fedoraproject.org/wiki/Packaging:PHP#Naming_scheme the package should be named php-libvirt instead of libvirt-php. Note that you have included the html doc in both main package and the -doc subpackage. Also the %doc must be on the same line as the filename specification. The licensing is confusing/wrong - in the README you specify that the license is GPL (if so, there should be COPYING with the correct GPL version). In the .spec file there is License: PHP. The source files do not contain any copyright statements nor license names - these are not required but they are recommended. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review