[Bug 683127] Review Request: TPM Quote Tools - TPM-based attestation using the TPM quote operation (tools)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683127

--- Comment #3 from John D. Ramsdell <ramsdell@xxxxxxxxx> 2011-03-08 13:14:58 EST ---
(In reply to comment #1)

Thanks for you quick reply.  I fixed the errors in my local copy of the spec
file, although I still don't see where the instructions say the Packager and
Vendor tags should be omitted.  I ran rpmlint, and it didn't complain about the
tags, or maybe it did, and I didn't understand the warning I received.

I don't understand what is wrong with my review summary.  I thought I was
supposed to supply the name of the package followed by a hyphen and then the
summary from the spec file.  Please tell me what I should have written.

> Please fix your review summary:
> 
> http://fedoraproject.org/wiki/PackageMaintainers/Join#Create_Your_Review_Request
> 
> Also take a look at Packaging Guidelines:
> 
> http://fedoraproject.org/wiki/Packaging/Guidelines
> 
> * The Packager tag should not be used in spec files.
> * The Vendor tag should not be used.
> 
> Do you plan to release an EPEL5 package? Read about BuildRoot tag.
> 
> Remove trousers explicit Require.
> 
> Why package INSTALL file?
> 
> Check "Parallel make" section under Guidelines too.
> 
> You should understand most of this process before ask for sponsoring...
> so, let's read the docs :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]