Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674188 --- Comment #14 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2011-03-08 04:19:58 EST --- Some notes for 0.3.4-1 * Cleanups for old stuffs - Unless you are going to maintain this package on EPEL, * BuildRoot tag is not needed * %clean section is not needed * "rm -rf %{buildroot}" on the first line of %install is not needed any longer. https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean * BR (BuildRequires) - Your srpm does not build. http://koji.fedoraproject.org/koji/taskinfo?taskID=2893255 * At least "BR: glib2-devel" is needed * Maybe gtk-doc is also needed for BR * License - Files under examples/ are under GPLv3. The license tag on -devel subpackage should be "LGPLv3 and GPLv3". * %?isa specific Requires - Now dependencies between main and -devel (sub)packages must be %{?isa} specific: https://fedoraproject.org/wiki/Packaging/Guidelines#Requires http://lists.fedoraproject.org/pipermail/devel-announce/2011-February/000750.html * Timestamps - When installing files with "cp" or "install" commands, please add -p option to keep timestamps on installed files. https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps - Please consider to use ----------------------------------------------------------------- make install DESTDIR=%{buildroot} INSTALL="install -p" ----------------------------------------------------------------- to keep timestamps on installed header files. This method usually works for Makefiles generated by recent autotools. * %configure option - build.log shows: ----------------------------------------------------------------- 44 + ./configure --build=i386-redhat-linux-gnu --host=i386-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --disable-static --disable-module 45 configure: WARNING: unrecognized options: --disable-module ----------------------------------------------------------------- I don't see --disable-module takes effect on configure.ac . Would you check if "--disable-module" is really needed? * Build process verbosity - Please add "V=1" to "make %{?_smp_mflags}" to show the linkage process of generated binaries. Currently build.log only shows: ------------------------------------------------------------------ 281 zeitgeist-data-source.c:386:31: warning: variable 'priv' set but not used [-Wunused-but-set-variable] 282 CCLD libzeitgeist-1.0.la 283 make[3]: Leaving directory `/builddir/build/BUILD/libzeitgeist-0.3.4/src' 284 make[2]: Leaving directory `/builddir/build/BUILD/libzeitgeist-0.3.4/src' ------------------------------------------------------------------ * %check - As this package contains tests/ directory and Makefile actually supports "make check", please add %check section and execute some test program there. * %files - Files or directories under %_datadir/gtk-doc are autumatically marked as %doc (so you don't have to write explicit %doc attribute). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review