Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682130 --- Comment #4 from Parag AN(àààà) <panemade@xxxxxxxxx> 2011-03-08 02:34:59 EST --- Suggestions: 1) split changelog lines to 80 character per line 2) versions are not needed in Requires: and BuildRequires: 3) Include ChangeLog file as %doc but looks like ChangeLog file carries contents from ibus-table ChangeLog file. 4) Good if upstream will add information related to ibus-indic-table project in %doc files and just mention in README that this project is a fork from ibus-table project. 5) I think you don't need file pinyin_table.txt.bz2 installed. 6) I also see template.txt should be modified to have unique uuid. Overall, it will be good if you will release a new tarball and package it as an update. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review