Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=681424 --- Comment #7 from Jeffrey Ness <jeffrey.ness@xxxxxxxxxxxxx> 2011-03-03 09:33:18 EST --- Carl, Ralf is correct in the %clean portion is not needed for Fedora 13 or above, but as we discussed this will be ported to EPEL 5/6 as well: http://fedoraproject.org/wiki/PackagingGuidelines#.25clean In this perl package your perl_privlib is the same across the board, I would like to see you narrow your top portion down to a single define: %define pvendorlib %{perl_vendorlib} Ralf this variable is used in Carl's %file portion: %files %defattr(644,root,root) %{_mandir}/man3/Net::SSH::Expect.3pm.gz %{pvendorlib}/Net/SSH/Expect.pm %{pvendorlib}/Net/SSH/Expect.pod I am also not quite sure why you have '_use_internal_dependency_generator' set to 1, in the documentation below it would seem it is always enabled unless set off by setting to '0': http://fedoraproject.org/wiki/PackagingDrafts/FilteringAutomaticDependencies -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review