Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675388 --- Comment #17 from BjÃrn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> 2011-02-28 19:59:03 EST --- (In reply to comment #16) I'm afraid Dmitrij was a little too eager to finish this review. > + The package must meet the Packaging Guidelines. > ==== + With new Ada guide too. It doesn't meet the recently approved Ada guidelines: Â "BuildRequires: gcc-gnat" is missing. Â The project files contain a hard-coded directory name: "../../include/xmlada". Â "Requires: fedora-gnat-project-common >= 2" is missing from the -devel package. Â The project files aren't placed in %{_GNAT_project_dir}. > * Every binary RPM package (or subpackage) which stores shared library files > (not just symlinks) in any of the dynamic linker's default paths, must call > ldconfig in %post and %postun. > Package contain symlinks in %{_libdir}. So it doesn't technically put the libraries in %{_libdir}, but don't they still need to get into the linker's cache somehow? How will that happen if ldconfig isn't run? > + A package must own all directories that it creates. It doesn't own the directory %{_libdir}/xmlada/relocatable. > + In the vast majority of cases, devel packages must require the base package > using a fully versioned dependency: Requires: %{name}%{?_isa} = > %{version}-%{release} "%{?_isa}" is missing. Some other things I have noticed: Â What is the empty directory %{_libdir}/xmlada/static needed for? Â The group of the -devel subpackage should be "Development/Libraries". Â The documentation should be in the -devel subpackage, except for COPYING. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review