Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Text-ASCIITable - Create a nice formatted table using ASCII characters https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219979 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From panemade@xxxxxxxxx 2006-12-18 00:23 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMS. + source files match upstream. 25fea1cef17be49a6da1d9b5267fba97 Text-ASCIITable-0.18.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + %check used make test + ./Build test t/01_default........ok t/02_custom.........ok t/03_options........ok t/04_multiline......ok t/05_wordwrap.......ok t/06_htmlstrip......ok t/07_aligning.......ok t/08_heading........ok t/09_ansistrip......ok t/10_pages..........ok t/11_overloading....ok t/12_chaining.......ok All tests successful. Files=12, Tests=105, 1 wallclock secs ( 0.24 cusr + 0.07 csys = 0.31 CPU) + Provides: perl(Text::ASCIITable) = 0.18 perl(Text::ASCIITable::Wrap) = 0.2 + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Dose owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Followed perl packaging guidelines. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review