Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Pod-Spell - A formatter for spellchecking Pod https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219950 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From panemade@xxxxxxxxx 2006-12-18 00:02 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMS. + source files match upstream. aa4964844da2586562aae5208e2dbe61 Pod-Spell-1.01.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + %check used make test PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl 1..22 # Running under perl version 5.008008 for linux # Current time local: Sun Dec 17 23:54:19 2006 # Current time GMT: Mon Dec 18 04:54:19 2006 # Using Test.pm version 1.25 # Perl version 5.008008 under linux ok 1 # Pod::Spell version 1.01 # Pod::Wordlist version 1.01 ok 2 # I see 1001 keys in %Pod::Wordlist::Wordlist # # Universe tests... # I'm in ASCII world. ok 3 # "A" is 65 ok 4 # "\n" is 10 ok 5 # "\r" is 13 ok 6 # "\cm" is 13 ok 7 # "\cj" is 10 ok 8 # "\t" is 9 ok 9 # "\f" is 12 ok 10 # "\b" is 8 ok 11 # "\a" is 7 ok 12 # "\e" is 27 # Universe tests complete. #------------------------ # Real tests. # ok 13 # Wrote >psin.pod (length 123 bytes) ok 14 # Opened <psin.pod and >psout.txt ok 15 # Created parser object. ok 16 # Converted. # Destroyed objects. # psout.txt is 26 bytes long. ok 17 # Opened <psout.txt ok 18 # Done reading 26 bytes from psout.txt. ok 19 # Content: TEST myormsp snickh. ok 20 # Converted content is indeed 'TEST myormsp snickh'. ok 21 # Unlinked psout.txt ok 22 # Unlinked psin.pod + Provides: perl(Pod::Spell) = 1.01 perl(Pod::Wordlist) + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Dose owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Followed perl packaging guidelines. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review