Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673589 --- Comment #31 from Sergio Belkin <sebelk@xxxxxxxxx> 2011-02-26 18:21:13 EST --- (In reply to comment #29) ***The new and corrected files*** Spec URL: http://dl.dropbox.com/u/14217893/UpTools.spec Spec URL: http://dl.dropbox.com/u/14217893/UpTools-8.5.4-9.fc16.src.rpm ***Below, the comments to Mamoru comments*** Again thanks Mamoru > Almost okay. > > * Timestamps > - Please consider to use > --------------------------------------------------------------- > make install DESTDIR=%{buildroot} INSTALL="install -p" > --------------------------------------------------------------- > to keep timestamps also on installed header files. > This method usually works for Makefiles generated by > recent autotools. Fixed!! > > ? %check > - $ make tests seems to generate example binaries, however > these binaries are not packaged into binary rpms, and > no actual testsuite is executed. Is %check section really > needed? Removed! Really not needed. They are code examples. > > Also please address Ralf's comments. Done it! Mamoru, Are you my sponsor? If you are not, please could you be it? Thanks all of your time and advices have been really useful! Greetings -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review