[Bug 673589] Review Request: UpTools - C++ library for hpc, networking, db, memory, etc.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673589

Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |mtasaka@xxxxxxxxxxxxxxxxxxx
               Flag|                            |fedora-review?

--- Comment #29 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2011-02-26 14:33:02 EST ---
Almost okay.

* Timestamps
  - Please consider to use
---------------------------------------------------------------
make install DESTDIR=%{buildroot} INSTALL="install -p"
---------------------------------------------------------------
    to keep timestamps also on installed header files.
    This method usually works for Makefiles generated by
    recent autotools.

? %check
  - $ make tests seems to generate example binaries, however
    these binaries are not packaged into binary rpms, and
    no actual testsuite is executed. Is %check section really
    needed?

Also please address Ralf's comments.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]