Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665081 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |iarnell@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |iarnell@xxxxxxxxx Flag| |fedora-review+ Bug 665081 depends on bug 664910, which changed state. Bug 664910 Summary: Review Request: perl-Plack - Perl Superglue for Web frameworks and Web Servers (PSGI toolkit) https://bugzilla.redhat.com/show_bug.cgi?id=664910 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |ERRATA Status|ON_QA |CLOSED Bug 665081 depends on bug 664982, which changed state. Bug 664982 Summary: Review Request: perl-Parallel-Prefork - Simple prefork server framework https://bugzilla.redhat.com/show_bug.cgi?id=664982 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |ERRATA Status|ON_QA |CLOSED Bug 665081 depends on bug 665005, which changed state. Bug 665005 Summary: Review Request: perl-Server-Starter - Superdaemon for hot-deploying server programs https://bugzilla.redhat.com/show_bug.cgi?id=665005 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |ERRATA Status|ON_QA |CLOSED --- Comment #1 from Iain Arnell <iarnell@xxxxxxxxx> 2011-02-26 00:55:32 EST --- + source files match upstream. 222eff2e8e5d69a44a8a3935fb8837cd Starlet-0.13.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=2868586 + package installs properly. + rpmlint has no complaints: perl-Starlet.src: W: spelling-error %description -l en_US Prefork -> Preform, Proreform, Prefatory 2 packages and 0 specfiles checked; 0 errors, 1 warnings. + final provides and requires are sane: perl(Plack::Handler::Starlet) perl(Plack::Server::Standalone::Prefork::Server::Starter) = 0.07 perl(Starlet) = 0.13 perl-Starlet = 0.13-1.fc16 perl(Starlet::Server) = perl >= 0:5.008_001 perl(base) perl(Carp) perl(constant) perl(HTTP::Date) perl(HTTP::Status) perl(IO::Socket::INET) perl(List::Util) perl(:MODULE_COMPAT_5.12.3) perl(Parallel::Prefork) perl(Plack) perl(Plack::Handler::Starlet) perl(Plack::HTTPParser) perl(Plack::TempBuffer) perl(Plack::Util) perl(POSIX) perl(Server::Starter) perl(Socket) perl(Starlet) perl(Starlet::Server) perl(strict) perl(Time::HiRes) perl(Try::Tiny) perl(warnings) + %check is present and all tests pass. All tests successful. Files=4, Tests=94, 4 wallclock secs ( 0.03 usr 0.01 sys + 1.10 cusr 0.22 csys = 1.36 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. I think the description is a little weak. If it were mine, I would rewrite it, but it's up to you: Starlet is a standalone HTTP/1.0 server with support for keep-alive, prefork, graceful shutdown, hot deploy, fast HTTP processing, and is suitable for running HTTP application servers behind a reverse proxy. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review