Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673589 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #25 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2011-02-24 14:51:23 EST --- Some notes: * Macros https://fedoraproject.org/wiki/Packaging/RPMMacros - Please use macros properly. For example. /usr/bin should be replaced by %{_bindir} ! By the way, "/usr/bin/" part before iconv is just redundant. * Compilation flags - Would you explain why "-Wno-deprecated" is needed (i.e. why do you want to suppress warnings?) * Parallel make https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make - Support parallel make if possible. If impossible, please write some comments on the spec file about it. * Timestamps https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps - When installing files with "install" or "cp" commands, please add "-p" option to keep timestamps on installed files: * %defattr - Now we prefer to use %defattr(-,root,root,-) * Dependency - UpSsl.h under %_includedir/UpTools contains: ----------------------------------------------------------------- 50 #ifndef USE_YASSL 51 #include <openssl/ssl.h> 52 #include <openssl/x509.h> 53 #include <openssl/rsa.h> 54 #include <openssl/engine.h> ----------------------------------------------------------------- looks like "Requires: openssl-devel%{?_isa}" is also needed on -devel subpackage ! By the way, I prefer to write one Requires per one line because - It is easier to read - It makes diff output smaller and more readable when Requires items changed. * Messages on scriptlets - Generally showing messages (especially non-error messages) when executing scriptlets (%post and so on) is forbidden. Instruction for creating example executables or so should be written and be installed as a file, and should not appear during scriptlets are executed. * Miscs - Why do you want to list each example files under doc/tests explicitly? (i.e. please use glob) - Also are there any reason you don't want to use %name-devel directory under %_defaultdocdir? Allowing to use such directory and using %doc in the spec file is much simpler and easier to read. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review