[Bug 679613] Review Request: python-flask - A microframework for Python based on Werkzeug, Jinja 2 and good intentions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=679613

--- Comment #3 from Dan Young <dyoung@xxxxxxxxxxxxxx> 2011-02-24 13:48:25 EST ---
Thanks for the quick feedback. New spec and SRPM here:
http://files.mesd.k12.or.us/~dyoung/python-flask/python-flask.spec
http://files.mesd.k12.or.us/~dyoung/python-flask/python-flask-0.6.1-2.fc14.src.rpm

Changes:
* Thu Feb 24 2011 Dan Young <dyoung@xxxxxxxxxxxxxx> - 0.6.1-2
- fix rpmlint spelling warning
- BR python2-devel rather than python-devel
- run test suite in check

Also, I'd appreciate some feedback on how I'm building the docs. Upstream uses
Sphinx, which is apparently D/Ling from the web at build time for "intersphinx
inventory". My understanding is that koji builds are not allowed network
access, nor do we want any external sources anyways. It's not clear to me that
these are "sources" in the traditional sense. I'm considering patching out this
function, although I frankly don't think I yet fully understand the
ramifications of just nuking it entirely or letting it timeout if network
access is denied:

http://sphinx.pocoo.org/latest/ext/intersphinx.html
https://bitbucket.org/birkenfeld/sphinx/issue/547/timeout-for-remote-intersphinx-inventory

Any insights you might have here are welcome.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]