Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=680020 --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-02-24 03:55:06 EST --- Hi Brendan, here are some initial notes on your package: - the package doesn't build in mock due to a missing BR: python-lxml - The license file must only be added if it's part of the source tarball. Since it's currently not present there, please drop it from the spec, and ask upstream to add it to the archive. (https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text) - move the for loop to the %prep section - If you plan to maintain the package for EPEL < 6 too, add a %clean section. Otherwise, you can drop all the buildroot stuff. - please be a bit more verbose in %files to avoid accidentally putting unwanted files into the package: %{python_sitelib}/pyquery/ %{python_sitelib}/pyquery*.egg-info/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review