Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678929 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |iarnell@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |iarnell@xxxxxxxxx Flag| |fedora-review+ --- Comment #2 from Iain Arnell <iarnell@xxxxxxxxx> 2011-02-23 23:35:18 EST --- + source files match upstream. 56251a6c909e21f5ae535b0e2af3897e Crypt-Random-Source-0.07.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text included. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=2862731 + package installs properly. + rpmlint has no complaints: perl-Crypt-Random-Source.noarch: W: spelling-error Summary(en_US) pluggable -> plug gable, plug-gable, plugged perl-Crypt-Random-Source.src: W: spelling-error Summary(en_US) pluggable -> plug gable, plug-gable, plugged 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + final provides and requires are sane: perl(Crypt::Random::Source) = 0.07 perl(Crypt::Random::Source::Base) = 0.07 perl(Crypt::Random::Source::Base::File) = 0.07 perl(Crypt::Random::Source::Base::Handle) = 0.07 perl(Crypt::Random::Source::Base::Proc) = 0.07 perl(Crypt::Random::Source::Base::RandomDevice) = 0.07 perl(Crypt::Random::Source::Factory) = 0.07 perl(Crypt::Random::Source::Strong) = 0.07 perl(Crypt::Random::Source::Strong::devrandom) = 0.07 perl(Crypt::Random::Source::Weak) = 0.07 perl(Crypt::Random::Source::Weak::devurandom) = 0.07 perl(Crypt::Random::Source::Weak::rand) = 0.07 perl-Crypt-Random-Source = 0.07-1.fc16 = perl >= 0:5.008 perl(Any::Moose) perl(bytes) perl(Capture::Tiny) perl(Carp) perl(Crypt::Random::Source::Factory) perl(Errno) perl(File::Spec) perl(IO::File) perl(IO::Handle) perl(:MODULE_COMPAT_5.12.3) perl(Module::Find) perl(namespace::clean) perl(strict) perl(Sub::Exporter) perl(warnings) + %check is present and all tests pass. PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/blocking.t ............ ok t/dev_random.t .......... ok t/factory.t ............. ok t/proc.t ................ ok t/rand.t ................ ok t/release-eol.t ......... skipped: these tests are for release candidate testing t/release-pod-syntax.t .. skipped: these tests are for release candidate testing t/reread.t .............. ok t/sugar.t ............... ok All tests successful. Files=9, Tests=53, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.42 cusr 0.06 csys = 0.52 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review