Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668052 Tomas Mraz <tmraz@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(stefanb@xxxxxxxxx | |m) --- Comment #6 from Tomas Mraz <tmraz@xxxxxxxxxx> 2011-02-23 08:13:27 EST --- A few more comments: 1. Not that it is blocker by any means but why do you use your own space on sourceforge? The sourceforge project files can be properly referenced too: https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net 2. You should not use the %release in the "upstream" tarball - this should be used only for the package n-v-r bumps for the spec file changes. 3. The parallel make flags are %{_smp_mflags} - do not hardcode -j9 there. https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make 4. Use %post -p /sbin/ldconfig etc. - see https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries You do not have anything else in the %post %postun scripts so this is the better way because it also adds automatically the Requires(post). Also do not call ldconfig in %post/%postun of the devel package. 5. Do not use %defattr(755, root, root) - it is confusing and may lead to mistakes use %defattr(-, root, root, -) 6. Although it is not strictly required I suggest adding V-R of the package to the changelog entries as in https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs Also the changelog entries should be separated by empty line for better readability. 7. The license of the package should be included in the tarball in a separate COPYING or LICENSE file and included as %doc in the main package. 8. You should use $RPM_BUILD_ROOT in %clean consistently with the rest of the spec. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review