Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650280 VÃt Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from VÃt Ondruch <vondruch@xxxxxxxxxx> 2011-02-23 06:26:21 EST --- * Dependency - I see no reason for the sed at line 58. There is no dependency mentioned in any of the specified files. * Unnecessary prep section - If there is no "sed" in prep section, the "gem install" could be moved into install section. This is not MUST, however it would simplify the spec file a bit. * Test suite - Some specs are not executed (there are 7 specs missing). The test suite should be executed by following command preferably: ruby -rubygems -Ilib/ -S rspec spec - What about executing Cucumber test suite? But there is probably missing packaged Aruba gem :/ * Koji: - Builds fine on Koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2859806 Neither one of the above is showstopper, so the package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review