Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650283 VÃt Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #7 from VÃt Ondruch <vondruch@xxxxxxxxxx> 2011-02-23 04:29:56 EST --- (In reply to comment #4) > (In reply to comment #3) > > At first, could you please explain how are you going to build all these > > packages? I assume that in first iteration, you are going to change > > need_bootstrap to 0 and in the second iteration, you are going to remove this > > constant and conditions completely, is that right? > > - As you see "Depends on" field on this bug, with version-compatible > rubygem-rspec-{expectations,mocks} installed as BR, bootstrapping > is not needed. > (So the reason that need_bootstrap craft is added to -core spec file > is only that I want to make all rubygem-rspec-foo related spec file > alike). > > ! Note that for rubygem-rspec-{expectations,mocks}, bootstrapping > is always needed if we want to enable tests, everytime we upgrade > the version of rspec related gems. > So if I understand it correctly, you plan to import and build rubygem-rspec-{expectations,mocks}, which will not have executed the %check section while rubygem-rspec-core could be successfully build with executed test suite, right? > > * Test suite > > - The test suite is really tricky :/ I have tried to run all the specs and > > there > > are failing not only for autospec part, also for formatters. I have created > > several upstream bugs to cover this: > > https://github.com/rspec/rspec-core/issues/318 > > https://github.com/rspec/rspec-core/issues/319 > > - Cucumber specs has several failures as well > > https://github.com/rspec/rspec-core/issues/320 > > - It is not hopefully showstopper > > - The selected subset works just fine > - Well, I am using > $ ruby -rubygems -Ilib/ ... > note that "-Ilib/" is used here, which may explain the difference of test > results between you and me. There apparently some issues with test suite. Some of them are already fixed upstream and some are waiting for their fix: https://github.com/rspec/rspec-core/issues/324 I hope it is not showstopper unless upstream will say so. > > * Documentation > > - Files in -doc subpackage are not marked as documentation. That is reported > > by rpmlint. They can by appropriately queried later: > > $ rpm -qp -d noarch/rubygem-rspec-core-doc-2.5.1-1.fc14.noarch.rpm > > > > - It is messaged by rpmlint > - It is intentional. I always say that "%doc attribute in -doc subpackage > is redundant" because > - The name of rpm already says that the package is for documentation > - If --excludedocs is specified with $ rpm -ivh (or similar effect is > set in rpm config file by default), files marked as %doc won't > be installed, although the admin is just about to install -doc > package to see document files, which is perhaps not expected. In our case, when we include spec or test suite in doc subpackage is this statement questionable. However it is discussion for fedora-devel then for this review. I have no other objections. So this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review