[Bug 678727] Review Request: pam-afs-session - AFS PAG and AFS tokens on login (sponsor requested)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678727

--- Comment #2 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> 2011-02-23 01:16:04 EST ---
Steve,

Thank you for your suggestions.

(In reply to comment #1)
> though in this case I appreciate it supersedes the normal "use
> name of tar ball" which you followed.

I'm fine with changing it to pam_afs_session. You are right, I was trying to
follow the tarball name convention. Do I need to change the name to use
underscores?

> 2)
> A very recent addition to the "rules" is to add %{?_isa} to the 
> end of your -devel Buildrequires. e.g.

I incorporated your %{?_isa} suggestion in 2.1-2

Updated Spec (2.1-2): http://adiemus.org/~kdreyer/rpms/pam-afs-session.spec
F14 build (2.1-2): http://koji.fedoraproject.org/koji/taskinfo?taskID=2859436

> Report back here with some links to some reviews you have made.

A few days ago I reviewed #678199 . I can do more reviews next week if
necessary.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]